Typing fix #147
Open
Typing fix #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter loading self._log_alpha from an optim_state_dict.
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 22.56% 22.56%
=======================================
Files 128 128
Lines 7987 7987
=======================================
Hits 1802 1802
Misses 6185 6185
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type comments are not prevalent in the codebase, but some type inference can be done automatically (e.g. using class definitions). This type comment is syntactically incorrect in that it causes mypy to throw an error. python 2 backward compatible comments either have to be on a line with a variable assignment, on a line with a function signature, immediately after a function signature, or on each line of a multiline function signature. The existing comment is neither. This small PR moves the comment to right after the function signature, and adds the type for the itr parameter too.
Longer term it would be really nice to have a stub file, if only the auto-generated one, so that mypy can check the types of the classes used in this package.
@astooke